Update blacklisted props that can be passed to native HTML elements using the transferProps principle #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
reviewed
Jan 17, 2024
mbohal
force-pushed
the
feature/update-transfer-props-blacklist
branch
from
459397e to
4955bcf
Compare
mbohal
commented
Jan 19, 2024
adamkudrna
reviewed
Feb 12, 2024
bedrich-schindler
requested changes
Feb 13, 2024
adamkudrna
reviewed
Feb 21, 2024
|
One more thing: please clean up the commits a bit, not all of them are fixups. Thank you! 
|
|
@adamkudrna wrote:
I would prefer to deal with documentation once we decide if we want to make the As per comment I dont know what to write. The concept is describe already. the individual blacklisted props are what they are. I can not come up with anything other then banal sentences like Could you please either write the comments yourself or at least make an example? I'm obviously not really able to do it myself. |
adamkudrna
reviewed
Feb 28, 2024
mbohal
force-pushed
the
feature/update-transfer-props-blacklist
branch
from
3d1b799 to
80c627e
Compare
|
It is rebased and ready for CR. |
dacerondrej
approved these changes
Mar 11, 2024
bedrich-schindler
approved these changes
Mar 19, 2024
…sing the transferProps principle Update src/components/_helpers/transferProps.js Co-authored-by: Adam Kudrna <[email protected]> Update src/components/_helpers/transferProps.js Co-authored-by: Adam Kudrna <[email protected]> Update src/components/_helpers/transferProps.js Co-authored-by: Adam Kudrna <[email protected]>
mbohal
force-pushed
the
feature/update-transfer-props-blacklist
branch
from
80c627e to
9c1ba79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.